Merge pull request #15 from laszlocph/generic-sidecar

Generic sidecar support

charts/onechart/templates/deployment.yaml

@@ -90,14 +90,16 @@ spec:
           {{- end }}
           resources:
             {{- toYaml .Values.resources | nindent 12 }}
-        {{- if .Values.debugSidecarEnabled }}
-        - name: {{ template "robustName" .Release.Name }}-debug
+        {{- if .Values.sidecar }}
+        - name: {{ template "robustName" .Release.Name }}-sidecar
           securityContext: *securityContext
-          image: {{ .Values.debugSidecar.image }}
+          image: {{ .Values.sidecar.repository }}:{{ .Values.sidecar.tag }}
+          {{- if .Values.sidecar.command }}
           command:
-            - {{ .Values.debugSidecar.shell }}
+            - {{ .Values.sidecar.shell }}
             - -c
-            - {{ .Values.debugSidecar.command | quote }}
+            - {{ .Values.sidecar.command | quote }}
+          {{- end }}
           {{- if or (or (.Values.vars) (.Values.secretEnabled)) .Values.sealedSecrets }}
           envFrom: *envFrom
           {{- end }}

charts/onechart/tests/deployment_debug_sidecar_test.yaml

@@ -1,12 +0,0 @@
-suite: test deployment
-templates:
-  - deployment.yaml
-  - configmap.yaml
-tests:
-  - it: Should add a debug sidecar
-    set:
-      debugSidecarEnabled: true
-    asserts:
-      - equal:
-          path: spec.template.spec.containers[1].image
-          value: debian:stable-slim

charts/onechart/tests/deployment_sidecar_test.yaml

@@ -0,0 +1,25 @@
+suite: test deployment
+templates:
+  - deployment.yaml
+  - configmap.yaml
+tests:
+  - it: Should inject a sidecar if one is specified
+    set:
+      sidecar:
+        repository: debian
+        tag: stable-slim
+    asserts:
+      - equal:
+          path: spec.template.spec.containers[1].image
+          value: debian:stable-slim
+  - it: Should inject a debug sidecar with shell and command specified
+    set:
+      sidecar:
+        repository: debian
+        tag: stable-slim
+        shell: "/bin/bash"
+        command: "while true; do sleep 30; done;"
+    asserts:
+      - equal:
+          path: spec.template.spec.containers[1].image
+          value: debian:stable-slim

charts/onechart/values.yaml

@@ -44,12 +44,6 @@ secretEnabled: false
 
 shell: "/bin/sh"
 
-debugSidecarEnabled: false
-debugSidecar:
-  image: debian:stable-slim
-  shell: "/bin/bash"
-  command: "while true; do sleep 30; done;"
-
 podDisruptionBudgetEnabled: true
 spreadAcrossNodes: false
 

values.yaml

@@ -9,3 +9,9 @@ fileSecrets:
         a
         multiline
         secret
+
+sidecar:
+  repository: debian
+  tag: stable-slim
+  shell: "/bin/bash"
+  command: "while true; do sleep 30; done;"