Moved volume support to common

charts/common/templates/_pvc.yaml

@@ -0,0 +1,18 @@
+{{- define "common.pvc.tpl" -}}
+{{- range .Values.volumes }}
+{{- $robustName := include "common.robustName" $.Release.Name }}
+---
+apiVersion: v1
+kind: PersistentVolumeClaim
+metadata:
+  name: {{ printf "%s-%s" $robustName .name }}
+  namespace: {{ $.Release.Namespace }}
+spec:
+  accessModes:
+    - {{ .accessMode | default "ReadWriteOnce" }}
+  storageClassName: {{ .storageClass | default "local-path" }}
+  resources:
+    requests:
+      storage: {{ .size | default "1Gi" }}
+{{- end }}
+{{- end -}}

charts/common/templates/_volumeMountsRef.yaml

@@ -0,0 +1,19 @@
+{{- define "common.volumeMountsRef.tpl" -}}
+{{- if or (or (.Values.volumes) (.Values.sealedFileSecrets)) .Values.fileSecrets }}
+volumeMounts: &volumeMounts
+{{- range .Values.volumes }}
+  - name: {{ .name }}
+    mountPath: {{ .path }}
+{{- end }}
+{{- range .Values.sealedFileSecrets }}
+  - name: {{ .name }}
+    mountPath: {{ .path }}
+    readOnly: true
+{{- end }}
+{{- range .Values.fileSecrets }}
+  - name: {{ .name }}
+    mountPath: {{ .path }}
+    readOnly: true
+{{- end }}
+{{- end }}
+{{- end }}

charts/common/templates/_volumesRef.yaml

@@ -0,0 +1,20 @@
+{{- define "common.volumesRef.tpl" -}}
+{{- if or (or (.Values.volumes) (.Values.sealedFileSecrets)) .Values.fileSecrets }}
+volumes:
+  {{- range .Values.volumes }}
+  - name: {{ .name }}
+    persistentVolumeClaim:
+      claimName: {{ printf "%s-%s" $.Release.Name .name }}
+  {{- end }}
+  {{- range .Values.sealedFileSecrets }}
+  - name: {{ .name }}
+    secret:
+      secretName: {{ printf "%s-%s" $.Release.Name .name }}
+  {{- end }}
+  {{- range .Values.fileSecrets }}
+  - name: {{ .name }}
+    secret:
+      secretName: {{ printf "%s-%s" $.Release.Name .name }}
+  {{- end }}
+{{- end }}
+{{- end -}}

charts/cron-job/templates/cronJob.yaml

@@ -38,20 +38,11 @@ spec:
                 - secretRef:
                     name: {{ .Release.Name }}
                 {{- end }}
-              volumeMounts:
-                {{- range .Values.volumes }}
-                - name: {{ .name }}
-                  mountPath: {{ .path }}
-                {{- end }}
+              {{- include "common.volumeMountsRef.tpl" . | nindent 14 }}
               resources:
                 {{- toYaml .Values.resources | nindent 16 }}
-          volumes:
-            {{- range .Values.volumes }}
-            - name: {{ .name }}
-              persistentVolumeClaim:
-                claimName: {{ printf "%s-%s" $.Release.Name .name }}
-            {{- end }}
-            {{ with .Values.nodeSelector }}
+          {{- include "common.volumesRef.tpl" . | nindent 10 }}
+          {{ with .Values.nodeSelector }}
           nodeSelector:
             {{ toYaml . | nindent 8 }}
           {{- end }}

charts/cron-job/templates/pvc.yaml

@@ -1,15 +1 @@
-{{- range .Values.volumes }}
----
-apiVersion: v1
-kind: PersistentVolumeClaim
-metadata:
-  name: {{ printf "%s-%s" $.Release.Name .name }}
-  namespace: {{ $.Release.Namespace }}
-spec:
-  accessModes:
-    - {{ .accessMode | default "ReadWriteOnce" }}
-  storageClassName: {{ .storageClass | default "local-path" }}
-  resources:
-    requests:
-      storage: {{ .size | default "1Gi" }}
-{{- end }}
+{{- include "common.pvc.tpl" . -}}

charts/onechart/templates/deployment.yaml

@@ -102,23 +102,7 @@ spec:
             {{- toYaml . | nindent 12 }}
             {{- end }}
           {{- end }}
-          {{- if or (or (.Values.volumes) (.Values.sealedFileSecrets)) .Values.fileSecrets }}
-          volumeMounts: &volumeMounts
-            {{- range .Values.volumes }}
-            - name: {{ .name }}
-              mountPath: {{ .path }}
-            {{- end }}
-            {{- range .Values.sealedFileSecrets }}
-            - name: {{ .name }}
-              mountPath: {{ .path }}
-              readOnly: true
-            {{- end }}
-            {{- range .Values.fileSecrets }}
-            - name: {{ .name }}
-              mountPath: {{ .path }}
-              readOnly: true
-            {{- end }}
-          {{- end }}
+          {{- include "common.volumeMountsRef.tpl" . | nindent 10 }}
           resources:
             {{- toYaml .Values.resources | nindent 12 }}
         {{- if .Values.sidecar }}
@@ -138,24 +122,7 @@ spec:
           volumeMounts: *volumeMounts
           {{- end }}
         {{- end }}
-      {{- if or (or (.Values.volumes) (.Values.sealedFileSecrets)) .Values.fileSecrets }}
-      volumes:
-        {{- range .Values.volumes }}
-        - name: {{ .name }}
-          persistentVolumeClaim:
-            claimName: {{ printf "%s-%s" $.Release.Name .name }}
-        {{- end }}
-        {{- range .Values.sealedFileSecrets }}
-        - name: {{ .name }}
-          secret:
-            secretName: {{ printf "%s-%s" $.Release.Name .name }}
-        {{- end }}
-        {{- range .Values.fileSecrets }}
-        - name: {{ .name }}
-          secret:
-            secretName: {{ printf "%s-%s" $.Release.Name .name }}
-        {{- end }}
-      {{- end }}
+      {{- include "common.volumesRef.tpl" . | nindent 6 }}
       {{- with .Values.nodeSelector }}
       nodeSelector:
         {{- toYaml . | nindent 8 }}

charts/onechart/templates/pvc.yaml

@@ -1,16 +1 @@
-{{- range .Values.volumes }}
-{{- $robustName := include "robustName" $.Release.Name }}
----
-apiVersion: v1
-kind: PersistentVolumeClaim
-metadata:
-  name: {{ printf "%s-%s" $robustName .name }}
-  namespace: {{ $.Release.Namespace }}
-spec:
-  accessModes:
-    - {{ .accessMode | default "ReadWriteOnce" }}
-  storageClassName: {{ .storageClass | default "local-path" }}
-  resources:
-    requests:
-      storage: {{ .size | default "1Gi" }}
-{{- end }}
+{{- include "common.pvc.tpl" . -}}

values-cron-job.yaml

@@ -9,3 +9,9 @@ shell: "/bin/sh"
 
 vars:
   MY_VAR: "value"
+
+volumes:
+  - name: data
+    path: /data
+    size: 10Gi
+    storageClass: default

values.yaml

@@ -15,3 +15,9 @@ gitSha: xyz
 
 vars:
   MY_VAR: "value"
+
+volumes:
+  - name: data
+    path: /data
+    size: 10Gi
+    storageClass: default