From d91040c0a036a110cdd4ad65aebc0ef3590a89f3 Mon Sep 17 00:00:00 2001
From: Laszlo Fogas <laszlo@laszlo.cloud>
Date: Thu, 5 Aug 2021 10:56:29 +0200
Subject: [PATCH] Job constraints configurable

---
 charts/cron-job/charts/common-0.1.0.tgz        | Bin 958 -> 959 bytes
 charts/cron-job/templates/cronJob.yaml         |   7 +++----
 .../tests/cronjob_costraints_test.yaml         |  17 +++++++++++++++++
 charts/cron-job/values.yaml                    |   6 ++++++
 charts/onechart/charts/common-0.1.0.tgz        | Bin 958 -> 957 bytes
 5 files changed, 26 insertions(+), 4 deletions(-)
 create mode 100644 charts/cron-job/tests/cronjob_costraints_test.yaml

diff --git a/charts/cron-job/charts/common-0.1.0.tgz b/charts/cron-job/charts/common-0.1.0.tgz
index c0eadeed61e4ecb7f3696900563ec9ba05f81731..7eb888ecbb4d542ca95a4c4a1e5350c418a256b0 100644
GIT binary patch
delta 895
zcmV-_1AzR#2fqi9O@B_jsDZs$WDB(D-(pjwK$|ugNn?o{id0F;-mK%I@6b2wlN6Nl
zpBA}jnzVq=1w{_daE9WXv7FhevSzqnk_+;bD!ujaNRlL(?(VkFBuQ>RlhJf<YqUE`
z#xKT`>2$J{jK;gu7h6dFfn4sO@qye{^0#B%KHPr<RI5XFUVm9L!(uF`t}mA(Ihx8u
z<m@x2>d@L=;WO41vRE#dTZb>2l%3(gUKpx)hOVGQIIVdGtx`wsR4gv`Oyo!=;;9e4
z!6nZ1AGoSD1@^<^%$m6>Dyko>9o(n?y*v8f+nbCx`hN_pRs-ZbSBBB+YC&EVK&W*O
zgY{ZOmYPEzl7DX4%LO@)^;+C$9wTw0Og_VY>;4thqT)a~1)2$<YYwXwE-LLZoU>`;
z!`D=C5ArQ*CeJc1V}#Dp*OYbMHwdk{V`)lR`xppllQo%caz?LYT@BiHB|A<J5@#^V
z<ZJ?VqkETQbaP}1#<LSX-NCa3Y0O^UIdlxrQm|gPIe)dpGyL4x&}I`iVw3;HG``NK
zzVvIjtN)U9&CbWmf1num>wkP(|H*W+(f?y$wHo%ZP}K~c1LjI|{N;XG#n+ORJVSrD
zUJDUvV&8ET?v-E>N(#uxAZ0Y3bCAFGMF7X%HZJ2<#5*9<5`2^9wjyQXV#!*Iqa}X-
z^*4M;L4O%&4uPHDL9PlF{0<tEv-6pCjOWMCA;r;mEuFMR+5{XeAw`?!pER@U-KFbf
za9r^Fw_Iz=_?6b^{qR#V_~g~#dm4N=K01;=ejIy5Z_vXTTt`FixOZ;RcF7KB2(B?1
zrjvH6s)J@eSMSd`(eTFch2dr+c<LL!iF5tS*ncNgVXWhak8!X5CwIR8r!V$4`hN^;
z;|)c<8INGmRRESH8>EfWxiST6%1)?YFU2;#Emah7U0WACe92m)&^ARyAuE+BcHmf3
zPzy#)p}b}%lZ$N_E-3z$!2j!3Ae>{VLW%!<B=L>Wr?95=j47dJ2dxZCAzvRH9|Y@I
zY<Oe8Em<7yA0SuG3t6ZzY{xErA=3|T*p3&5vKYqUV(AxVc(qYV*-2Bkz0Zrj^vhcG
zWlATaFGCgQ)~Q1De-Ya_B&TfS@%igdy^yuD?>GxWs+?)q(VcxK<ick*=i$Fh>KkmZ
V!3H<*M*si-|Np&EQhERs000y>#4-Q?

delta 894
zcmV-^1A+X%2fhc8O@B!o)WBW@*#a&4x7ZXZ(54MW(pch#B2|*IH|x0QJM<0vBn74X
zr$sKBCN1D|L6L(qoS`^pEN8Z=tQj7Z<bph-N^d+qk|aqcJ3H+&Ns_zIWHi~`810Ob
z@!ohenT$4)(RgRFy@BK($mJdyAINPae>>LQ!~I7<wK`(wm47u;%*TT2`f53nqlrvJ
z&OURh4y|n;pRulx#d5*SI(*Tj><kC?!cfIibOj~CS<O>ul{#`~Vt%=2B1bY2&wc1M
zu5h9Mz*Vg&upgde*348<QT=G`;356*-qZi??s&4+|5ISO93bbJGK^kV3-Y=ELalok
ztX3kj)C}^7bbrHM&dGVKR^nFk7>QG5@+l5l_phiH6$i>G&{P0jb675MS!q|{oJ|`a
zzNU(MkZ)Ntd6sb*BXo|wrmXY6MQF_(OH<0)$3Q@vtjTnfGkPWKYS6YT*>QT1IEPUt
zXA`g!-Mbv4n<G;&UYzpT7GBIrWBTgep<{rSg4L?csedJ&<LAbPHk-H+oBS`P@pV4;
zrQg7P{g<q3c0OMIBgJ@F|Kq#*Pj>g#`hN;6m%~2hs+z)cz)We5zud2?_*$}(r|1t?
zD<L9H95{}`y%sD&NdXxdq>RRM4)Qm?2;kV;#%0`!cnf4&f^X8?R-{Z^ELdxCyuk0j
z{)R6pD1QUZA+YmX$W@_&-$G+@c0RL?@$%#)q&WVrrIXf3n}Fj5q-fLplV*0ayL6ol
zjthSOmTOHJ?`w_T4?iV?Pxc4j)8NC&@v;2z<Jcp5gC5S|IvRQ>y$g%B3wAh1aE-|@
z*>0z*I&5Y$_5Okr4R0J@8g4g&=f3gVxX{0heScCF#yWod7!T@y``-8eWN)<A|5IQS
zZz$@`cm#{C0<b9AAZ?V+l_^kDc1i_%DK_zKsiJ`E+PdK3OV%2NwkawKS*c911;?6#
znlow&<qbQTTx`N{LGiBy{$IBO;T#JUO8oC5iEoTPgEg&ZObInRXk}Om`TFqWFj&W8
z6L$w~$>QkX5V>+*$U=o-J9g;{nSOA?cDyu{#V`(+OFuWm>y1*%PMf;zeO~mXU(}*6
zQ#uuW8LBw9P8Fj6i`c{wIb|D<&tHG)g{+-@$5{|k<xInl?(91u=RUJJ5C3ISUt^6m
U*0_Z~0ssL2|0WF;v;Y(U04K-6?EnA(

diff --git a/charts/cron-job/templates/cronJob.yaml b/charts/cron-job/templates/cronJob.yaml
index ddf5db3..d999ed8 100644
--- a/charts/cron-job/templates/cronJob.yaml
+++ b/charts/cron-job/templates/cronJob.yaml
@@ -7,10 +7,9 @@ metadata:
     {{- include "helm-chart.labels" . | nindent 4 }}
 spec:
   schedule: {{ .Values.schedule | quote }}
-  successfulJobsHistoryLimit: 1
-  failedJobsHistoryLimit: 1
-  concurrencyPolicy: Forbid
-  startingDeadlineSeconds: 120
+  {{ with .Values.constraints }}
+    {{ toYaml . | nindent 2 }}
+  {{- end }}
   jobTemplate:
     spec:
       template:
diff --git a/charts/cron-job/tests/cronjob_costraints_test.yaml b/charts/cron-job/tests/cronjob_costraints_test.yaml
new file mode 100644
index 0000000..f430172
--- /dev/null
+++ b/charts/cron-job/tests/cronjob_costraints_test.yaml
@@ -0,0 +1,17 @@
+suite: test cron job
+templates:
+  - cronJob.yaml
+tests:
+  - it: Should have default constraints
+    asserts:
+      - equal:
+          path: spec.successfulJobsHistoryLimit
+          value: 1
+  - it: Should constraints be configurable
+    set:
+      constraints:
+        successfulJobsHistoryLimit: 2
+    asserts:
+      - equal:
+          path: spec.successfulJobsHistoryLimit
+          value: 2
diff --git a/charts/cron-job/values.yaml b/charts/cron-job/values.yaml
index 462dcc5..f0bca92 100644
--- a/charts/cron-job/values.yaml
+++ b/charts/cron-job/values.yaml
@@ -27,3 +27,9 @@ affinity: {}
 
 secret:
   enabled: false
+
+constraints:
+  successfulJobsHistoryLimit: 1
+  failedJobsHistoryLimit: 1
+  concurrencyPolicy: Forbid
+  startingDeadlineSeconds: 120
diff --git a/charts/onechart/charts/common-0.1.0.tgz b/charts/onechart/charts/common-0.1.0.tgz
index 2b9cdb872299268226fda58e9ec1400c8e18e4e9..2f255ff54d95dccf80b8d8b669655b35c2467808 100644
GIT binary patch
delta 911
zcmV;A191Gl2fYW7Jb&A6<2De@Gr!{0Szuc?rsZ6`sDXV5vISc7w%8OY(54MW(pch#
zB2|*IH|x0QKlBg#B?YD2-69W7lP=)%K#_wpoS`^pEN8Z=tQj7Z<bph-N^d+ok|asS
zySwc(Ns_zIWHjE}810Ud?HAiS<MC)C8Ex;5_coCH2f3`E@qdBbM)I#?-96j~0;<&!
zJFl#nV74u&uCJCOIU37E<m@x2>d@Nu@dfJ&Su7V!t;1JM%Fb|LFAP;YL03>BoYg#m
zR;eR*CT5p=CUPVb@zjT2;|dr04_wun0{h`fX3bO;71a;c4(`+c-irSB_I8rB{vQL2
z#Q-@^m0|R{T7Qt&1rTc8!(h1-k)@`PN2D9}az@T$xfHjW$4HzilTUEax_?8ps5nqg
zfhGdzn!{p&%SyWn=WN>e@GVu`gM7o9$+L{h7@>3YHD#UmEkbMVSejDSJ_Z8XWKE`<
zoY5;;SA(`)$&S;5#5s&IIh%mp=-%ZR-5i;M@$8h(wtw(!MjDfsD~FB&S_+oSHm8<&
zj$a!a+HB%RZ1R7Y#@G4Omwp4Q`Y&16?0mfZ2a0jO{<rVyKN*kK`hN^87Q;Sfs+z!a
zz*K3DzuYgY_*$}(C+H8COCcgn95{}`y%sD&NdXxdq>RRM4)Qm?2;kV;#%0`!cnf4&
zf^X8?R)3^ST+CT(aXiPLzyE=+DJTQYA+YmX$W@_&-$G+@c0RL?@%-dDq&WVerIXf3
zn}Fjvq-fLpn`U;iyL6oljthSGhHFh3?`w_TProFC&-MpD(%}8c@v;2*)7T?=gC5S|
zIvRQ>y$g%Bb9OjKaE-|@-f5?*I&7v>_3nZb4S%m4Um9*Vf~UUm+qlrbjD1oS#yWoZ
z829RbXXX2U{9<RV|Hr^4UQ^VY@dy@O1z=vXLE0#tD^sAR?34=jQf%V;QbhsRwROS6
zm#j4kZBtYfvQn913yw7fHDlBi${Thvx!8o^g5qBZd|bBz;T&@nN__N*#CJxY!J5`H
zrhkN*9kenmg?x2*au}>*v5AAWWN~zGh+H`@WTC>a9lP{}Oy9d<J6;;fVi<?ZrJtGM
z^+qXWr%m1VJ}>&x&uh__DV>VG3{{+4rwY;kO>E+boU)C_m#;qeLe|c{<tzxPa;9NN
lclNE2GoRU<hyOFFud&7&Yuv(L0RRC1{|He_TJiuC002kn)F%J{

delta 912
zcmV;B18@Aj2fhc8Jb&G8<2Dn`HJ{>q&I0?@jcM8IIH-ZWSY!*d=-*;fq(GZC7)fJ^
z8;Vp(%HFKwqVLc*?2{Cf@}CyDXqvQu&jm#e&Txj}oUxqQs<LLdUy=**lq$XT@JNy*
znNB9{Gf9%$&tx>+-5O0s$#`!(+8a%`lF@iFoopfb2XeWC#(xKLTgl&!b^CDt5m2oT
z*?DEn42!X#y1rbF<Y+1rk+aX7szYmgh0j=5$YQx*ZXLd8Qg(&|dts>J8M=ZJ;k4!%
zv`QVhQ?a<%Gm#^ih^IdE2A4S3f8eUt6xa`sGi&CmsHlFhc5t8mckk$bcXzzE(f?y$
zwHhGjxiXAiSAPrgssKW*dl;<OBC^yR@{n}HUM|Ratk>d3^B9Q}W%3#JTlcT178M7|
zDbP#+U2|Bia8YTO;haqyAHJrFdysEgGkKPA86$L#zNW16zCmcs9ZOTn+Q&dZo2<!n
zlQViH>uS)pE7@^+kT`=;CT9~ciSAvF(an)57|%}lbbklW7NjwIdFRkEKuf`T-R9I1
z&+v0&Lz_+9h)w<%)A%}{`qHoAuKr8bH9H?K|AAuMumACF{U_68qyNXiYBlU*p{f}?
z2h5e`_{;sWimxRrd4~RQy%r+U#J=Mw+$+H%loXJWLCR=6=OBOWivW(jZCu8!h<8Ay
zCHN-IZGT0|#Kn@e7Dr3`{_Ah}l7ceO90EJPgIpCV_#HGRXXi8P7|)NNLyDvCS~_Ws
zv<Wy`LW(xcKWS#yyGz%};JD!TZ@Jc#@hh#-`{Ac#@X4#e_cZu$d~_s#{5bZA-k^sw
zxQ>S2aqrxs?UEhN5L{z2OkcE9RUI_*xq5%jiGPMSjxP*18^KfG_)VPaU&cPE3S%8V
ze2jbb|KiT~|8#G>(f?y$8*eD;&3FWht^%+u*&uC{&Xp-pQ+7fHdnvZ@ZK<Mw>)N{D
z;Y-#Ug|;aw3R$U4u>;4Nf?6<Y3gtCBnOtnca6$2}1pZ&Q0^uA>6-xZ?BZ+T}K7}={
zXMaoyH9Kf!SPJ?2;P@a|$6_1%ZOP(r{{XpiUdTd)VLNu|3z>d!!*;wdl*KR(7fZh|
z!>f%_%1)ZP?R{SKrC-*fFH<@ZeHp4aw@wwJ|BKkhAvt9mkI!F!>V>SGeaBf4Qsqp;
mj_&L`As0TgIS>D3Qr}>M4K}!eKLP*%{|Wy_`WVFk6aWCbsMK%(