From c7da3a4a4fdc911ce3fc1f4705b5018e092507ef Mon Sep 17 00:00:00 2001 From: Raz Amir <88726761+ramir-savvy@users.noreply.github.com> Date: Tue, 7 Nov 2023 14:01:15 +0200 Subject: [PATCH] Add podLabels to onechart (#83) * Add podLabels to onechart * add unittest --- charts/onechart/charts/common-0.4.0.tgz | Bin 2140 -> 2141 bytes charts/onechart/helm-ui.json | 3 ++- charts/onechart/templates/deployment.yaml | 3 +++ .../tests/deployment_podlabels_test.yaml | 17 +++++++++++++++++ charts/onechart/values.schema.json | 13 +++++++++++++ charts/onechart/values.yaml | 3 ++- 6 files changed, 37 insertions(+), 2 deletions(-) create mode 100644 charts/onechart/tests/deployment_podlabels_test.yaml diff --git a/charts/onechart/charts/common-0.4.0.tgz b/charts/onechart/charts/common-0.4.0.tgz index a2ea195f9adaaeb0fedef0804891deee48ddba94..c1a4d6986a981afed930e0cee9dbd94074243976 100644 GIT binary patch delta 1994 zcmV;*2Q~QI5Zw@vsek{(84L%#!O5P}J?RZk_Q3fDveYP&iikbutH-K-+zTNR(km2_ z27Cnb6U#&C3K}X?ehq&?=7X#E22270e~ZQ_I4YDDCq9lK-aVGO3vmRDjs+2S);#Uc zv3s^-J@*&xXc;B?uh0(}Q7Ai~+<;H$)FM>Py3_xyP?P>QY=9CH z#9ET+MZh8-Gu4QJVnP|FI{Xb_qS$>EA`Y4{A{{}4NPnUE2p%%fF!g5vR~i{A7?FHi ztjqu}K(n7lb^S*^e=7q20wJd`0wXbpF7VN55By4oDijR!sC?u!fP)}*@r&ya;Eq+a_Cjj>YyPkL4T zcZS`a{%?cs?>k2@r~U{eD$q);HT9LRr^TJ&2#z{B`q6CGnLur|a%%-@MijV&!x$lw z=zjr`g(NWultCn1G%9-xgc}AKjlIAplY=lmkPhP{?EO=#(mX z3=#KGNH-7&KYjWMZ0q`?VJD2iI8tzZ3$|s%Yyh*OX^nvl1WxhG1%`~c_?j_jU0;9v z{}$NLYPaA4MEnL?pIS)`3vN-s11J%37k>t)=8^iB(PTou7@jgRJolQeLv{TR=kA6N zf>yd#5}5za45&8NC6XmhVa2U>+zF3g$ruBh&|b7D#nY)U1$jvC$9J-5XkD zPUDZmw9A76!i-+683AZVq%q-iu4|-1uCB}%7$KkLiWKBo*AK~4V&U9<&3T}R4u6^w z&x7O@dG1;T{~$iAHK-({O8F>DhUn@Zi0h)1?*b2#4%;T4$*T*oTI&Ld_fb%VAGnLH zvb0hKf=u-!$wby-&HF4;s`C|q5HbspNF(rbgi^^gBuZK*UC}>E;&p$eRb*{;zn)u% zUNY73KMrQ!ZZHa5iT~Xy{tt%3(|;ZQZ-W}}zqSFE7=tRW{3aMariv4v+HT-?=3T3nLEwWIV$qodex-;D}SoIt+CdP z?Tvq30rwO%;+ZH;ektAcM27g#~380b`DxLpVB7?#mfWp~P{Y1YQOz2UI;*8+OV)5zO zsTq;y0!_M>a;n;`*zY_{4{MtbynQ{2_KD+Hq4th508a8G(fGVjofMOVM)_T19z(xq zDn231+JxL|i492(hj<@2yBmQvY|C#QOkSMCO}p@WmAwAAzD-?(|9=~TenTtp|KxO7 z#sB{Bbcg?2p@sPW{XoAgd&!OWP8Vrss)E_ELsFlXM{r-zJSH*bt{zRK&9b{v^(#XQ z+mw1PUtC?*;W`&!D}!X`F3HQZoQ@G@@RPnN!B#$N*=uzd7JUBrE=Q?-nV}SX6ogC4 zVbe*>s4{l>EGg^S)qlnJ^;s`--QSl6tTtOKBUSmBC3YMd_vxCpI}Rwb1Cs0p+IoVQ zg#HS z;1W~-@eY978FCm$lzEg-Atde%nWD6XNXwp5)iJ-Z_?A8XLv+k3eDXoX&u?} zHnfiHF}bmhY(wSi=RnY@b@WebAFha?K_ua?Z+?-M9g5(0bd_aO4@oCx7s2nAJ(q6a cVP}UfJKE8XzGwPx00030|5-IB1pq<-0Aso0g8%>k delta 1993 zcmV;)2R8WK5Zn-useiva9G(t)&dHwBJ?RadJ#fB(EH#RxB4W?^>anUH_dRrTq5JzbcsQXP zp%w21JKq2*WG!evK3bZKPQbn*EJA6|iIDL4XqCXDYu!-pjo{2Qe@8;gM@2lM$jAbS z@#6j-(w&wKCxUS#)qCP&3+xMINF>_2s7Ht!%8k@;hj=2~aBa?a{03$4SS>z$K zX2|@uK`=Y!X@7wY55Ot+kSplv=CO>rnIL?MaBzcn$8azw3`VbNAFT&4Eb#bfWHO8o z@Hq;Ukw$lf+*|Odr}McNy+956A4wJXZz;pG4I#lw{qGJd`akTS?(}~v)TI9n8=!;) zv6f_d5wOU|Of_Plm{5kP4u1ofD0W|kh=XQ~NJr2hQh#VZf`<$=O#NBFl}3gNMkL=B zD>J|g(CnvCUH_5K--^J$z{#c@fED`R9XeJ2zdzX7|LstN{ueet)d2_u{9OH4w2y~* zQKBnQ{ldwZp?7!)c|Bq1U7EMDSgk9xQs#B|g-S*FG=mCRf0uM*giHhz)BEJQo z4Q|@$1%FOrzu`|iDHSXz!(&y@Wcc`do5r?z25g!F6O0iSze`K-pjVAVOu>XO`E)Vz zxqQ+@Y)Y8IB9u19>gmWlxrUWEShWUEbF_lr&o9XRlBS9_;vbU$A4`E z<4@TV{yTkVP{aRze~16upa%ReY=9+hU(RKAe1E&$P8_?qvg-83DWVS{`5a-h#}^99 z)dX5U$o3DirrQM|TEpF27}Lq3t~SSW<3SI(`{Dw+HL0%uGh`tOsn>o(W31HwlU`N- zoxyOY|J$JZ`_2)}sXqdV3baydO?~C-X>n&bf}@U(el(kPCQw_g+**N}5d|*cFh+4Wjuc$qf^8Ww8^Ek+T4Nvsfm8f)fgvLl&$$t1I&bM#!hRA_aNY^+WQMSU7iIa~>$7gMX&P z^B{Rep1W4TKZwt24Jrw#Qa;L(A-cK;;<_m1yTHSw!?uZM^6EmY*1ACAeH2vT2kv64 zEUi?5AX7a_GLf}d^FE7|>U;$tgv!V6HubQ-fMSqpIHP*VZ zz45Or;GTj;JQKyqFQvPl9N4F=R<6VUTonF%v z_}?F%?C^gpv=INlALy55FS+sF=_2h+RWLhtNb1w_2<{7-$0Www)uV~DS$0>der0H3 zn^Mo^i>u2zT;~F8WsvOLC3%^a(=oyfe$qE3*ve-ud#&!mg3lk{(!`}@*>)n;pDq$(e?#EwJbK3&sx#{p$_K$6`+TTk$k z&|hJfw<68jHg~C1&ExK3&}K^Pzdb|d(BmeLUZ>?T1U3L z4Xq=4Om3_rTSEEzIS_Pe9sSeVhbtmz5J~v!n_r}5ha&hLU1izSL(+-aMew_2&!ro9 b*x8}Wj&`)8@0tD^00960o@(qY073u&Rf+2} diff --git a/charts/onechart/helm-ui.json b/charts/onechart/helm-ui.json index 87216fe..3f3f2e9 100644 --- a/charts/onechart/helm-ui.json +++ b/charts/onechart/helm-ui.json @@ -143,7 +143,8 @@ "schemaIDs": [ "#/properties/podDisruptionBudgetEnabled", "#/properties/spreadAcrossNodes", - "#/properties/podAnnotations" + "#/properties/podAnnotations", + "#/properties/podLabels" ], "uiSchema": {}, "metaData": { diff --git a/charts/onechart/templates/deployment.yaml b/charts/onechart/templates/deployment.yaml index e9b1ae0..f4eca98 100644 --- a/charts/onechart/templates/deployment.yaml +++ b/charts/onechart/templates/deployment.yaml @@ -39,6 +39,9 @@ spec: gimlet.io/git-repository: {{ .Values.gitRepository }} {{- end }} labels: + {{- with .Values.podLabels }} + {{- toYaml . | nindent 8 }} + {{- end }} {{- include "helm-chart.selectorLabels" . | nindent 8 }} spec: {{- with .Values.imagePullSecrets }} diff --git a/charts/onechart/tests/deployment_podlabels_test.yaml b/charts/onechart/tests/deployment_podlabels_test.yaml new file mode 100644 index 0000000..43c7936 --- /dev/null +++ b/charts/onechart/tests/deployment_podlabels_test.yaml @@ -0,0 +1,17 @@ +suite: test deployment +templates: + - deployment.yaml + - configmap.yaml +tests: + - it: Should set custom labels + set: + podLabels: + label1: val1 + label2: val2 + asserts: + - equal: + path: spec.template.metadata.labels.label1 + value: val1 + - equal: + path: spec.template.metadata.labels.label2 + value: val2 diff --git a/charts/onechart/values.schema.json b/charts/onechart/values.schema.json index a911c05..be2af2f 100644 --- a/charts/onechart/values.schema.json +++ b/charts/onechart/values.schema.json @@ -15,6 +15,7 @@ "nameOverride": "", "fullnameOverride": "", "podAnnotations": {}, + "podLabels": {}, "podSecurityContext": { "fsGroup": 999 }, @@ -189,6 +190,18 @@ "required": [], "additionalProperties": true }, + "podLabels": { + "$id": "#/properties/podLabels", + "type": "object", + "title": "Pod labels", + "description": "Annotations to place on pods", + "default": {}, + "examples": [ + {} + ], + "required": [], + "additionalProperties": true + }, "name": { "$id": "#/properties/name", "type": "string", diff --git a/charts/onechart/values.yaml b/charts/onechart/values.yaml index 79b2e0e..f0db6be 100644 --- a/charts/onechart/values.yaml +++ b/charts/onechart/values.yaml @@ -20,6 +20,8 @@ fullnameOverride: "" podAnnotations: {} +podLabels: {} + podSecurityContext: fsGroup: 999 @@ -39,7 +41,6 @@ nodeSelector: {} tolerations: [] - probe: enabled: false path: "/"