Removed envfrom -- Updated unittest

charts/common/templates/_envFromRef.yaml

@@ -1,24 +1,21 @@
 {{- define "common.envFromRef.tpl" -}}
-{{- if or (or (or (.Values.vars) (.Values.secretEnabled) (.Values.envFrom)) .Values.sealedSecrets) .Values.secretName -}}
+{{- if or (or (or (or (or (.Values.vars) (.Values.secretEnabled)) .Values.sealedSecrets) .Values.secretName) .Values.existingConfigMaps) .Values.existingSecrets -}}
 envFrom: &envFrom
 {{- if .Values.vars }}
   - configMapRef:
       name: {{ template "common.robustName" .Release.Name }}
 {{- end }}
-{{- if .Values.envFrom }}
+{{- range .Values.existingSecrets }}
-
-{{- range .Values.envFrom.existingSecrets }}
   - secretRef:
       name: {{ .name }}
       optional: {{ .optional }}
 {{- end }}
 
-{{- range .Values.envFrom.existingConfigMaps }}
+{{- range .Values.existingConfigMaps }}
   - configMapRef:
       name: {{ .name }}
       optional: {{ .optional }}
 {{- end }}
-{{- end }}
 
 {{- if .Values.secretEnabled }}
   - secretRef:

charts/onechart/templates/deployment.yaml

@@ -138,7 +138,7 @@ spec:
             - -c
             - {{ .Values.sidecar.command | quote }}
           {{- end }}
-          {{- if or (or (.Values.vars) (.Values.secretEnabled) (.Values.envFrom)) .Values.sealedSecrets }}
+          {{- if or (or (or (or (or (.Values.vars) (.Values.secretEnabled)) .Values.sealedSecrets) .Values.secretName) .Values.existingConfigMaps) .Values.existingSecrets }}
           envFrom: *envFrom
           {{- end }}
           {{- if or (or (.Values.volumes) (.Values.sealedFileSecrets)) .Values.fileSecrets }}

charts/onechart/tests/deployment_configmap_test.yaml

@@ -14,14 +14,18 @@ tests:
           content:
             configMapRef:
               name: release-name
+  - it: Should not reference configmap if vars are not set
+    asserts:
+     - isNull:
+         path: spec.template.spec.containers[0].envFrom
+
   - it: Should reference to existing configmaps
     set:
-      envFrom:
+      existingConfigMaps:
-        existingConfigMaps:
+      - name: firstcm
-        - name: firstcm
+        optional: true
-          optional: true
+      - name: secondcm
-        - name: secondcm
+        optional: true
-          optional: true
     asserts:
       - contains:
           path: spec.template.spec.containers[0].envFrom

charts/onechart/tests/deployment_secret_test.yaml

@@ -33,12 +33,11 @@ tests:
               name: release-name
   - it: Should reference to existing secrets
     set:
-      envFrom:
+      existingSecrets:
-        existingSecrets:
+      - name: firstsecret
-        - name: firstsecret
+        optional: true
-          optional: true
+      - name: secondsecret
-        - name: secondsecret
+        optional: true
-          optional: true
     asserts:
       - contains:
           path: spec.template.spec.containers[0].envFrom