From 230c34654773622a4201969c7792f1287365a9b4 Mon Sep 17 00:00:00 2001
From: Laszlo Fogas <laszlo@laszlo.cloud>
Date: Wed, 3 Mar 2021 13:51:49 +0100
Subject: [PATCH] NodePort

---
 charts/onechart/templates/service.yaml       |  2 +-
 charts/onechart/tests/service_type_test.yaml | 16 ++++++++++++++++
 charts/onechart/values.yaml                  |  2 ++
 3 files changed, 19 insertions(+), 1 deletion(-)
 create mode 100644 charts/onechart/tests/service_type_test.yaml

diff --git a/charts/onechart/templates/service.yaml b/charts/onechart/templates/service.yaml
index c6d0b7a..8cb8de4 100644
--- a/charts/onechart/templates/service.yaml
+++ b/charts/onechart/templates/service.yaml
@@ -6,7 +6,7 @@ metadata:
   labels:
     {{- include "helm-chart.labels" . | nindent 4 }}
 spec:
-  type: ClusterIP
+  type: {{ if .Values.nodePortEnabled }}NodePort{{ else }}ClusterIP{{ end }}
   ports:
     - port: {{ .Values.containerPort }}
       targetPort: http
diff --git a/charts/onechart/tests/service_type_test.yaml b/charts/onechart/tests/service_type_test.yaml
new file mode 100644
index 0000000..58a0851
--- /dev/null
+++ b/charts/onechart/tests/service_type_test.yaml
@@ -0,0 +1,16 @@
+suite: test deployment
+templates:
+  - service.yaml
+tests:
+  - it: Should have default ClusterIP type
+    asserts:
+      - equal:
+          path: spec.type
+          value: ClusterIP
+  - it: Should set NodePort if flag enabled
+    set:
+      nodePortEnabled: true
+    asserts:
+      - equal:
+          path: spec.type
+          value: NodePort
diff --git a/charts/onechart/values.yaml b/charts/onechart/values.yaml
index 1f4f146..8352486 100644
--- a/charts/onechart/values.yaml
+++ b/charts/onechart/values.yaml
@@ -53,3 +53,5 @@ debugSidecar:
 
 podDisruptionBudgetEnabled: true
 spreadAcrossNodes: true
+
+nodePortEnabled: false